chore(Tile): add controls args to every story#21612
chore(Tile): add controls args to every story#21612AFatmaa wants to merge 6 commits intocarbon-design-system:mainfrom
Conversation
|
All contributors have signed the DCO. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
emyarod
left a comment
There was a problem hiding this comment.
looks good to me but you will need to accept the DCO to pass CI!
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #21612 +/- ##
==========================================
- Coverage 94.62% 88.41% -6.22%
==========================================
Files 535 350 -185
Lines 43637 14894 -28743
Branches 6209 4919 -1290
==========================================
- Hits 41291 13168 -28123
+ Misses 2212 1600 -612
+ Partials 134 126 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I have read the DCO document and I hereby sign the DCO. |
|
Hi @emyarod, |
sangeethababu9223
left a comment
There was a problem hiding this comment.
Hey @AFatmaa ,
Thanks for working on this, the story controls look great in the React stories!
When you get a chance, could you also take a look at the WC stories? The issue affects both @carbon/react and @carbon/web-components.
Closes #20959
Adds controls args to every story of the tile component
Changelog
Changed
Testing / Reviewing
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
[ ] Wrote passing tests that cover this change[ ] Addressed any impact on accessibility (a11y)More details can be found in the pull request guide