fix: use uintptr_t to maintain pointer provenance #2845
Merged
+4
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingiler
changed the title
jiegec
reviewed
Jan 10, 2026
Rot127
requested changes
Jan 11, 2026
Collaborator
Rot127
left a comment
Rot127
left a comment
There was a problem hiding this comment.
Makes sense IMO.
But please add a note about it in https://github.com/capstone-engine/capstone/blob/next/docs/cs_v6_release_guide.md
Contributor
Author
|
Where should I add a note in the release guide? Should it be in |
Collaborator
|
I think it could go under |
notxvilka
approved these changes
Jan 11, 2026
jiegec
approved these changes
Jan 12, 2026
Collaborator
|
Never mind. I'll add it to the docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
On systems such as CHERI which distinguish integers and pointers,
uintptr_tshould be used to prevent pointer provenance issues.The fix allows capstone to be compiled and run on ARM Morello.
...
Test plan
N/A.
If a physical CHERI machine is not available, one can use cheribuild to build QEMU for Morello and CHERI-RISC-V and run code inside it.
...
Closing issues
N/A
...