feat: add tab roles/search role #387
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@47PADO47 Thanks for working on this! Can you rebase with latest changes so only the changes adding tab roles are in this PR? |
47PADO47
force-pushed
the
add-tab-search-role
branch
from
c8094e6 to
44dacd8
Compare
🦋 Changeset detectedLatest commit: 3fcb1e5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
done, let me know if anything needs to be changed. i also added a changelog entry, but noticed i forgot to add one for the pr #364. should i create it? |
packages/react-native-bottom-tabs/android/src/main/java/com/rcttabview/RCTTabViewImpl.kt
Outdated
Show resolved
Hide resolved
|
@okwasniewski i think everything's done, what do you say? |
fix: sync Podfile.lock
47PADO47
force-pushed
the
add-tab-search-role
branch
from
1f509ca to
3fcb1e5
Compare
Merged
|
Thank you for working on this! Merged in #390 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This pr adds support for ios tab roles
How to test?
Run the app on a mac and go into "sf symbols" example
Screenshots