Skip to content

fix: don't show default tab bar when channing theme and using a custom one #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025
Merged

fix: don't show default tab bar when channing theme and using a custom one #347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/little-dingos-cough.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'react-native-bottom-tabs': patch
---

fix: don't show a default tab bar on top of a custom one when changing theme
5 changes: 5 additions & 0 deletions packages/react-native-bottom-tabs/android/src/main/java/com/rcttabview/RCTTabView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,6 +458,11 @@ class ReactBottomNavigationView(context: Context) : LinearLayout(context) {
return
}

// User has hidden the bottom navigation bar, don't re-attach it.
if (bottomNavigation.visibility == GONE) {
return
}

// If appearance wasn't changed re-create the bottom navigation view when configuration changes.
// React Native opts out ouf Activity re-creation when configuration changes, this workarounds that.
// We also opt-out of this recreation when custom styles are used.
Expand Down
Loading