@@ -176,7 +176,20 @@ - (void)updateProps:(const Props::Shared &)props oldProps:(const Props::Shared &
176
176
if (oldScreenProps.maximumValue != newScreenProps.maximumValue ) {
177
177
[slider setMaximumValue: newScreenProps.maximumValue];
178
178
}
179
- updateLimits (slider, newScreenProps.lowerLimit , newScreenProps.upperLimit );
179
+ if (slider.lowerLimit != newScreenProps.lowerLimit ) {
180
+ if (newScreenProps.lowerLimit > slider.upperLimit ){
181
+ NSLog (@" Invalid configuration: upperLimit < lowerLimit; lowerLimit not set" );
182
+ } else {
183
+ slider.lowerLimit = newScreenProps.lowerLimit ;
184
+ }
185
+ }
186
+ if (slider.upperLimit != newScreenProps.upperLimit ) {
187
+ if (newScreenProps.upperLimit < slider.lowerLimit ){
188
+ NSLog (@" Invalid configuration: upperLimit < lowerLimit; upperLimit not set" );
189
+ } else {
190
+ slider.upperLimit = newScreenProps.upperLimit ;
191
+ }
192
+ }
180
193
if (oldScreenProps.tapToSeek != newScreenProps.tapToSeek ) {
181
194
slider.tapToSeek = newScreenProps.tapToSeek ;
182
195
}
@@ -267,21 +280,6 @@ - (void)loadImageFromImageSource:(ImageSource)source completionBlock:(RNCLoadIma
267
280
}
268
281
}
269
282
270
- void updateLimits (RNCSlider *slider, float newLowerLimit, float newUpperLimit) {
271
- if (slider.lowerLimit != newLowerLimit) {
272
- slider.lowerLimit = newLowerLimit;
273
- }
274
-
275
- if (slider.upperLimit != newUpperLimit) {
276
- slider.upperLimit = newUpperLimit;
277
- }
278
-
279
- if (slider.lowerLimit > slider.upperLimit ) {
280
- NSLog (@" Invalid configuration: lowerLimit > upperLimit, reverting lowerLimit to upperLimit." );
281
- slider.lowerLimit = slider.upperLimit ;
282
- }
283
- }
284
-
285
283
- (void )setInverted : (BOOL )inverted
286
284
{
287
285
if (inverted) {
0 commit comments