chore: pr improvements

Author: maciej.lodygowski

package/android/src/main/java/com/reactnativecommunity/slider/ReactSlider.java

@@ -239,9 +239,10 @@ private void updateLowerLimit() {
     double limit = Math.max(mRealLowerLimit, mMinValue);
     int lowerLimit = (int) Math.round((limit - mMinValue) / (mMaxValue - mMinValue) * getTotalSteps());
     if(lowerLimit > mUpperLimit) {
-      Log.w("Invalid configuration", "reverting lower limit to upper limit");
+      Log.d("Invalid configuration", "upperLimit < lowerLimit; lowerLimit not set");
+    }else {
+      mLowerLimit = Math.min(lowerLimit, mUpperLimit);
     }
-    mLowerLimit = Math.min(lowerLimit, mUpperLimit);
   }
 
   /** Update limit based on props limit, max and min
@@ -250,10 +251,11 @@ private void updateLowerLimit() {
   private void updateUpperLimit() {
     double limit = Math.min(mRealUpperLimit, mMaxValue);
     int upperLimit = (int) Math.round((limit - mMinValue) / (mMaxValue - mMinValue) * getTotalSteps());
-    if(mLowerLimit > upperLimit) {
-      Log.w("Invalid configuration", "reverting upper limit to equal to lower limit");
+    if (mLowerLimit > upperLimit) {
+          Log.d("Invalid configuration", "upperLimit < lowerLimit; upperLimit not set");
+    } else {
+          mUpperLimit = upperLimit;
     }
-    mUpperLimit = Math.max(upperLimit, mLowerLimit);
   }
 
   /** Update value only (optimization in case only value is set). */

package/ios/RNCSliderManager.m

@@ -162,21 +162,19 @@ - (void)sliderTouchEnd:(RNCSlider *)sender
   float lowerLimit = [RCTConvert float:json];
 
   if (lowerLimit > view.upperLimit) {
-    lowerLimit = view.upperLimit;
-    NSLog(@"Invalid configuration: reverting upper limit to equal to lower limit")
-  }
-
-  view.lowerLimit = lowerLimit;
+      NSLog(@"Invalid configuration: upperLimit < lowerLimit; lowerLimit not set")
+    } else {
+      view.lowerLimit = lowerLimit;
+    }
 }
 RCT_CUSTOM_VIEW_PROPERTY(upperLimit, float, RNCSlider) {
   float upperLimit = [RCTConvert float:json];
 
   if (upperLimit < view.lowerLimit) {
-    upperLimit = view.lowerLimit;
-    NSLog(@"Invalid configuration: reverting lower limit to equal to upper limit")
-  }
-
-  view.upperLimit = upperLimit;
+      NSLog(@"Invalid configuration: upperLimit < lowerLimit; upperLimit not set")
+    } else {
+      view.upperLimit = upperLimit;
+    }
 }
 RCT_EXPORT_VIEW_PROPERTY(minimumTrackTintColor, UIColor);
 RCT_EXPORT_VIEW_PROPERTY(maximumTrackTintColor, UIColor);

package/src/Slider.tsx

@@ -1,4 +1,4 @@
-import React, {useCallback, useEffect, useState} from 'react';
+import React, {useEffect, useState} from 'react';
 import {
   Image,
   Platform,
@@ -281,18 +281,14 @@ const SliderComponent = (
           default: constants.LIMIT_MAX_VALUE,
         });
 
-  const limitCheck = useCallback(() => {
+  useEffect(() => {
     if (lowerLimit >= upperLimit) {
       console.warn(
         'Invalid configuration: lower limit is supposed to me smaller than upper limit',
       );
     }
   }, [lowerLimit, upperLimit]);
 
-  useEffect(() => {
-    limitCheck();
-  }, [limitCheck, localProps]);
-
   return (
     <View
       onLayout={(event) => {