Skip to content

fix: fix configuration for fabric view templates #801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025

Conversation

satya164
Copy link
Member

@satya164 satya164 commented Mar 27, 2025

fixes #788

fabric view

CleanShot 2025-03-27 at 15 35 13@2x

CleanShot 2025-03-27 at 15 35 52@2x

turbo module

CleanShot 2025-03-27 at 15 37 29@2x

CleanShot 2025-03-27 at 15 39 23@2x

@satya164 satya164 requested a review from Copilot March 27, 2025 14:24
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the configuration for fabric view templates by updating export fields, adjusting the available option choices, and updating fallback dependency versions.

  • In packages/react-native-builder-bob, the exports configuration is simplified by unconditionally adding the package.json field.
  • In packages/create-react-native-library, the Fabric view option is reorganized to remove duplication and improve clarity.
  • The fallback Bob version in packages/create-react-native-library and instructions in the FAQ documentation are updated accordingly.

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

File Description
packages/react-native-builder-bob/src/init.ts Unconditionally adds './package.json' to exports, removing the previous conditional block.
packages/create-react-native-library/src/input.ts Reorders Fabric view option entries to remove duplication.
packages/create-react-native-library/src/index.ts Updates the fallback Bob version from 0.36.0 to 0.38.3.
docs/pages/faq.md Clarifies instructions regarding the package.json export field in package.json.
Files not reviewed (1)
  • packages/create-react-native-library/templates/common/$package.json: Language not supported
Comments suppressed due to low confidence (1)

packages/react-native-builder-bob/src/init.ts:245

  • Ensure that adding './package.json' unconditionally to exportsField does not lead to unexpected behavior compared to the previous configuration based on pkg.codegenConfig. If different behavior is needed when codegenConfig is active, consider reintroducing conditional logic or updating related tests.
      './package.json': './package.json',

@satya164 satya164 force-pushed the @satya164/fix-fabric-template branch from 155adb1 to bf71823 Compare March 27, 2025 14:26
@satya164 satya164 requested a review from atlj March 27, 2025 14:39
@satya164 satya164 added this pull request to the merge queue Mar 27, 2025
Merged via the queue into main with commit 212de62 Mar 27, 2025
22 checks passed
@satya164 satya164 deleted the @satya164/fix-fabric-template branch March 27, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS Fabric View template doesn't work when published and installed into a new app
2 participants