perf: Utilize layout files for routing form pages #21478
+58
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
cubic reviewed 3 files and found no issues. Review PR in cubic.dev.
hbjORbj
changed the title
hbjORbj
changed the title
hbjORbj
force-pushed
the
refactor/use-layout-for-routing-forms-forms
branch
from
08c31be to
4ddfc75
Compare
hbjORbj
changed the title
hbjORbj
changed the title
hbjORbj
changed the title
hbjORbj
commented
May 23, 2025
| @@ -14,20 +13,17 @@ import FormProvider from "./FormProvider"; | |||
|
|
|||
| const normalizePages = (pages: string[] | string | undefined) => { | |||
| const normalizedPages = Array.isArray(pages) ? pages : pages?.split("/") ?? []; | |||
| return { | |||
| mainPage: normalizedPages[0] ?? "forms", | |||
| subPages: normalizedPages.slice(1), | |||
There was a problem hiding this comment.
never used, hence not needed
| return await _generateMetadata( | ||
| (t) => (mainPage === "routing-link" ? `Form | Cal.com Forms` : `${t("routing_forms")} | Cal.com Forms`), | ||
| () => "", | ||
| undefined, | ||
| undefined, | ||
| `/apps/routing-forms/${(await params).pages.join("/")}` |
There was a problem hiding this comment.
/routing is correct since /apps/routing-forms is deprecated
Comment on lines
-51
to
-57
| if (mainPage === "forms") { | ||
| return ( | ||
| <Shell withoutMain> | ||
| <FinalComponent /> | ||
| </Shell> | ||
| ); | ||
| } |
There was a problem hiding this comment.
Moved to /routing-forms/forms/page.tsx and /routing-forms/forms/layout.tsx
| @@ -53,7 +45,7 @@ export async function getServerSideProps( | |||
|
|
|||
| return { | |||
| props: { | |||
| appUrl: app.simplePath || `/apps/routing-forms`, | |||
There was a problem hiding this comment.
app.simplePath is always /routing, and we don't need to call await getAppWithMetadata({ slug: "routing-forms" }) for this info
There was a problem hiding this comment.
cubic found 1 issue across 7 files. Review it in cubic.dev
React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.
hbjORbj
changed the title
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
hbjORbj
changed the title
E2E results are ready! |
zomars
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
/routing/forms