refactor: remove ring.mp3 tone for instant meetings #21404
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Co-Authored-By: [email protected] <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (05/19/25)1 reviewer was added to this PR based on Keith Williams's automation. |
devin-ai-integration
bot
changed the title
keithwillcode
requested changes
May 26, 2025
| }); | ||
| }); | ||
| }; | ||
| // Notification click handler for instant meetings removed |
There was a problem hiding this comment.
Can we not just remove this comment and the if statement?
| @@ -21,7 +20,7 @@ export function Providers({ isEmbed, children }: ProvidersProps) { | |||
| <SessionProvider> | |||
| <TrpcProvider> | |||
| {!isBookingPage ? <PlainChat /> : null} | |||
| {!isEmbed && !isBookingPage && <NotificationSoundHandler />} | |||
| {/* NotificationSoundHandler removed */} | |||
There was a problem hiding this comment.
Can we not just remove this completely?
|
Closing based on recommendation by @Udit-takkar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove ring.mp3 tone for instant meetings
This PR removes the feature that plays a ring.mp3 tone for instant meetings as requested. All instances of this functionality and the related service worker code have been removed.
Changes
Testing
yarn type-check:ciTZ=UTC yarn test(one failing test unrelated to these changes)Link to Devin run: https://app.devin.ai/sessions/0e103abbfa9f43b9aced6c86b6deb8b9
Requested by: [email protected]
Summary by cubic
Removed the ring.mp3 notification sound for instant meetings, including all related code and assets. Instant meetings will no longer play a sound when triggered.