refactor: use explicit TLS secret keys instead of map iteration#346
Open
racciari wants to merge 1 commit intocaddyserver:mainfrom
Open
refactor: use explicit TLS secret keys instead of map iteration#346racciari wants to merge 1 commit intocaddyserver:mainfrom
racciari wants to merge 1 commit intocaddyserver:mainfrom
Conversation
Replace map iteration over Secret.Data with explicit access to the standard Kubernetes TLS secret keys (tls.crt, tls.key). Benefits: - More explicit about expected secret structure - Follows Kubernetes TLS secret convention - Avoids including unexpected keys if secret contains extra data - Maintains conventional PEM order (certificate before key) No functional change for standard TLS secrets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace map iteration over Secret.Data with explicit access to the standard Kubernetes TLS secret keys (tls.crt, tls.key).
Benefits:
No functional change for standard TLS secrets.