Turn on new WIT metadata format by default #2201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is a follow-up to bytecodealliance#1508 where a new JSON format was added for storing docs/stability and accounting for world imports/exports allowing overlap. This support should have permeated far enough that it's reasonable to turn this on-by-default now. This additionally fixes fuzz bugs cropping up after adding support for stability annotations in the generated WIT, the other motivation for this.
jsturtevant
reviewed
May 22, 2025
| @@ -11,7 +11,7 @@ | |||
| ) | |||
| ) | |||
| (export (;1;) "console" (type 0)) | |||
| (@custom "package-docs" "\00{}") | |||
| (@custom "package-docs" "\01{}") | |||
There was a problem hiding this comment.
Why does this get bumped to 01? I don't really see reasoning in this PR but I assume it is due to the face this feature is no turned on?
There was a problem hiding this comment.
Ah that's around here where by changing the static this is changing the default emission as well
jsturtevant
approved these changes
May 22, 2025
alexcrichton
requested review from
a team and
abrown
and removed request for
a team
abrown
approved these changes
May 29, 2025
There was a problem hiding this comment.
I'm not sure I'm qualified to review this PR but @jsturtevant seems to think it is OK, so +1!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is a follow-up to #1508 where a new JSON format was added for storing docs/stability and accounting for world imports/exports allowing overlap. This support should have permeated far enough that it's reasonable to turn this on-by-default now.
This additionally fixes fuzz bugs cropping up after adding support for stability annotations in the generated WIT, the other motivation for this.