Revert "libc-wasi: Make rights of STDIN/STDOUT/STDERR fixed and overl… #4448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ook their access modes (bytecodealliance#3694)" This reverts commit 67fa155. because it broke certain use cases while it isn't clear what it fixed. tested with: https://github.com/yamt/garbage/tree/master/wasm/httpd https://github.com/yamt/garbage/tree/master/wasm/tty cf. bytecodealliance#4447 bytecodealliance#3686 (comment)
yamt
requested review from
loganek,
lum1n0us,
no1wudi,
TianlongLiang,
wenyongh and
xujuntwt95329
as code owners
|
I mostly agree that STDXXX can have variant But, are you suggesting that removing read/write bits based on the access mode is acceptable according to STDXX? switch (access_mode) {
case WASI_LIBC_ACCESS_MODE_READ_ONLY:
*rights_base &= ~(__wasi_rights_t)__WASI_RIGHT_FD_WRITE;
break;
case WASI_LIBC_ACCESS_MODE_WRITE_ONLY:
*rights_base &= ~(__wasi_rights_t)__WASI_RIGHT_FD_READ;
break;
} |
yes. i think it's the most straightforward behavior. |
lum1n0us
added
the
bug-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ook their access modes (#3694)"
This reverts commit 67fa155.
because it broke certain use cases while
it isn't clear what it fixed.
tested with:
https://github.com/yamt/garbage/tree/master/wasm/httpd
https://github.com/yamt/garbage/tree/master/wasm/tty
cf.
#4447
#3686 (comment)