fix: read API_TOKEN from database in certbot hooks#3296
Open
Upellift99 wants to merge 3 commits intobunkerity:devfrom
Open
fix: read API_TOKEN from database in certbot hooks#3296Upellift99 wants to merge 3 commits intobunkerity:devfrom
Upellift99 wants to merge 3 commits intobunkerity:devfrom
Conversation
This reverts commit 6fc701b.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
API_TOKENfrom certbot hook scripts (certbot-auth.py,certbot-cleanup.py,certbot-deploy.py)API_TOKENfrom the database viadb.get_non_default_settings()(already available throughDATABASE_URIwhich certbot preserves) instead of relying ongetenv("API_TOKEN")Fixes #3295
Validation steps
AUTO_LETS_ENCRYPT=yeson a servicecertbot renewalso works correctlyFiles changed
src/common/core/letsencrypt/jobs/certbot-auth.pysrc/common/core/letsencrypt/jobs/certbot-cleanup.pysrc/common/core/letsencrypt/jobs/certbot-deploy.py🤖 Generated with Claude Code