Lets Encrypt profiles: update Limits in code/readme #3251#3269
Open
mkf-sysangels wants to merge 4 commits intobunkerity:devfrom
Open
Lets Encrypt profiles: update Limits in code/readme #3251#3269mkf-sysangels wants to merge 4 commits intobunkerity:devfrom
mkf-sysangels wants to merge 4 commits intobunkerity:devfrom
Conversation
Lets Encrypt profiles: update Limits in code/readme bunkerity#3251 translations by claude.ai
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Let’s Encrypt plugin to reflect current certificate profile limits (notably the 25-SAN cap for tlsserver/shortlived) and improves DNS challenge behavior/documentation to reduce failed ACME attempts and debugging time.
Changes:
- Add SAN-limit enforcement per profile in
certbot-new.py, with clear logging and early deactivation when exceeded. - Scale DNS propagation wait time automatically when
LETS_ENCRYPT_DNS_PROPAGATION=default(10s × domain count). - Refresh plugin setting help text and translated READMEs to document profile constraints and ZeroSSL behavior.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/common/core/letsencrypt/plugin.json |
Expands help text for DNS propagation and certificate profile settings. |
src/common/core/letsencrypt/jobs/certbot-new.py |
Implements SAN-limit checks and default DNS propagation scaling logic. |
src/common/core/letsencrypt/README.md |
Documents profile SAN caps, ZeroSSL notes, and DNS propagation default scaling. |
src/common/core/letsencrypt/README.zh.md |
Updates Chinese docs to match new limits/behavior. |
src/common/core/letsencrypt/README.fr.md |
Updates French docs to match new limits/behavior. |
src/common/core/letsencrypt/README.es.md |
Updates Spanish docs to match new limits/behavior. |
src/common/core/letsencrypt/README.de.md |
Updates German docs to match new limits/behavior. |
fix merge conflict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets Encrypt profiles: update Limits in code/readme #3251
translations by claude.ai