feat : load config from local context instead of global variables #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaced direct usage of credentials from config with a new utility function `getBrowserStackAuth` to retrieve authentication details. - Updated multiple functions across various modules to accept `server` parameter for improved flexibility and maintainability. - Ensured all API calls to BrowserStack now utilize the new authentication method, enhancing security and code clarity. - Adjusted related function signatures and calls to accommodate the new parameter structure.
…rver parameter - Updated createTestRun, listTestCases, listTestRuns, updateTestRun, and uploadFile functions to include a server parameter. - Modified related test cases to pass mock server instances for better test isolation and accuracy. - Enhanced error handling and logging in test management tools. - Improved test coverage for various scenarios in test management utilities.
…ameters and handle local URL errors
…ated binary setup
…of server parameter - Updated listTestCases, listTestRuns, pollLCAStatus, createTestCasesFromFile, updateTestRun, uploadFile, and other related functions to accept BrowserStackConfig. - Modified the corresponding test cases to reflect the changes in function signatures and ensure proper configuration handling. - Enhanced error handling and logging for better debugging and traceability.
…e proper URL opening
…or BrowserStack integration
…ts implementation
…ove process management
…ith improved error handling and environment variable checks
sync with main
….json and package-lock.json
….ts has consistent import style fix: modify device cache to store live response data correctly
|
Tested with the pipeline — all tools are working. |
| @@ -38,6 +38,7 @@ | |||
| "@types/form-data": "^2.5.2", | |||
| "axios": "^1.8.4", | |||
| "browserstack-local": "^1.5.6", | |||
| "chitragupta": "github:browserstack/chitragupta-node", | |||
There was a problem hiding this comment.
is this needed in OSS version ?
There was a problem hiding this comment.
If we need logs from the remote server for tool execution, then yes, having them is needed.
Since the Chitragupta Node SDK is open source, I believe it's acceptable to include it in our OSS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.