Add sdk initial changes #23
Conversation
There was a problem hiding this comment.
Small cosmetic change for both statements, please modify as given below:
- To integrate BrowserStack Test Reporting & Analytics with Espresso, refer to our documentation
- To integrate BrowserStack Accessibility to functional tests and generate comprehensive reports of accessibility issues, refer to our documentation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces initial SDK changes for the espresso-browserstack project, updating project configuration, build scripts, library versions, and instrumentation tests. Key changes include adding plugin and dependency resolution management blocks, rewriting Gradle wrapper scripts (both bat and sh versions), updating AndroidManifest permissions and backup rules, and migrating test rules from ActivityTestRule to ActivityScenarioRule.
Reviewed Changes
Copilot reviewed 15 out of 18 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| settings.gradle | Added plugin management and dependency resolution configuration. |
| gradlew.bat | Updated batch script with enhanced comments and APP_HOME resolution. |
| gradlew | Rewritten shell script with shebang change, refactored JVM option handling, and new signal handling. |
| gradle/wrapper/gradle-wrapper.properties | Updated Gradle distribution URL and version. |
| gradle/libs.versions.toml | Added new versions for dependencies and plugins. |
| gradle.properties | Changed android.enableJetifier flag from true to false. |
| AndroidManifest.xml | Added Internet permission, cleartext traffic support, and new backup rules. |
| Instrumentation test files (e.g. ExampleInstrumentedTest.java, Ensure*Tests.java) | Migrated tests to use ActivityScenarioRule with additional test reporting and logging. |
| app/build.gradle | Migrated to new plugin DSL, updated SDK versions, and reconfigured dependencies. |
| README.md | Expanded documentation for test reporting and accessibility integrations. |
Comments suppressed due to low confidence (1)
gradlew:1
- Changing the shebang from bash to sh may introduce compatibility issues if any bash-specific syntax is used later; please verify the script runs as expected on all target systems.
#!/usr/bin/env sh
|
|
||
| APP_NAME="Gradle" | ||
| APP_BASE_NAME=`basename "$0"` | ||
|
|
||
| # Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script. | ||
| DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"' |
There was a problem hiding this comment.
The embedded quotes in DEFAULT_JVM_OPTS may lead to parsing issues in some shell environments; consider simplifying this definition to ensure consistent behavior across shells.
| DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"' | |
| DEFAULT_JVM_OPTS='-Xmx64m -Xms64m' |
Copilot uses AI. Check for mistakes.
| AccessibilityUtils.performEspressoAppAccessibilityScan(""); | ||
| Log.d("PERFORM_SCAN_LOGS", "afterScan"); | ||
|
|
||
| Thread.sleep(10000); |
There was a problem hiding this comment.
Using Thread.sleep for waiting in tests can lead to flakiness; consider replacing it with Espresso idling resources or other synchronization mechanisms.
Copilot uses AI. Check for mistakes.
No description provided.