Upgrade from Chromium 149.0.7827.23 to Chromium 149.0.7827.48 (1.91.x) DO NOT MERGE#36852
Closed
mkarolin wants to merge 5 commits into
Closed
Upgrade from Chromium 149.0.7827.23 to Chromium 149.0.7827.48 (1.91.x) DO NOT MERGE#36852mkarolin wants to merge 5 commits into
mkarolin wants to merge 5 commits into
Conversation
Chromium changes: https://chromium.googlesource.com/chromium/src/+/03d0729142a7f3db6bc6a16d69de16832cf32320 commit 03d0729142a7f3db6bc6a16d69de16832cf32320 Author: James Leung <jamesleung@google.com> Date: Thu May 14 22:43:43 2026 -0700 [voice_search] Keep voice search open during permission prompt Modify the composebox voice search to remain active when an embedded permission prompt is displayed. This prevents the voice search overlay from timing out or closing while the user interacts with system access requests. An observer must be added to communicate via mojo to the frontend when the voice search should remain active. Key changes include: * Implemented `EmbeddedPermissionPromptObserver` to track the lifecycle and bounds of the embedded permission prompt widget. When it resizes, closes due to out of focus, or closes due to an option being selected, it sends a mojo message (`OnEmbeddedPermissionPromptChanged`) * Added a new Mojo method `OnEmbeddedPermissionPromptChanged` to tell the frontend when the permission prompt is visible, and the prompt's size * Made page callback passed down to `cr-composebox-voice-search`. Also made it protected instead of private. * Updated `cr-composebox-voice-search` to listen for permission state changes, effectively pausing the idle timer when the permission prompt is visible. screencast/cast/NTU0NDc5Mjc3MDQ3ODA4MHxiYzc3ZmYyYy1hNQ NO_IFTTT=just rearranged and made existing property protected It is known that it should be moved to mixin. Bug: b:492201887 Change-Id: Ie85be91c7e2435bb519b7d5e92565674a1d5ffbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7744441 Commit-Queue: James Leung <jamesleung@google.com> Reviewed-by: Ananya Seelam <ananyaseelam@google.com> Cr-Commit-Position: refs/heads/main@{#1631087}
mkarolin
added
CI/skip-ios
github-actions
Bot
added
the
CI/storybook-url
Collaborator
Author
|
Closing in favor of #36951 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
THIS IS ANDROID ONLY PR -- DO NOT MERGE
Resolves brave/brave-browser#55942