Set CGO_ENABLED=1 to support FIPS-compatible builds #427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set CGO_ENABLED=1 in all containerfiles and the Makefile to allow [1] linking against FIPS-compliant C libraries (e.g. OpenSSL). This is a prerequisite for enabling strict FIPS runtime support:(e.g. via GOEXPERIMENT=strictfipsruntime and -tags strictfipsruntime) in downstream builds. No functional change expected in non-FIPS environments. [1] https://developers.redhat.com/articles/2025/01/23/fips-mode-red-hat-go-toolset#validating_fips_mode_capabilities Signed-off-by: Andrew McDermott <[email protected]>
|
This needs cross compiler support to work. Adding cross-compilers I found that the PPC build would intermittently fail with a SEGV. Either a genuine issue in gcc-ppc, or more likely an issue in QEMU as we're reliant on that for cross builds. |
msherif1234
pushed a commit
to msherif1234/bpfman-operator
that referenced
this pull request
Apr 15, 2025
…s/component-update-ocp-bpfman-operator-bundle chore(deps): update ocp-bpfman-operator-bundle to 2cef525
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set CGO_ENABLED=1 in all containerfiles and the Makefile to allow [1] linking against FIPS-compliant C libraries (e.g. OpenSSL).
This is a prerequisite for enabling strict FIPS runtime support:(e.g. via GOEXPERIMENT=strictfipsruntime and -tags strictfipsruntime) in downstream builds.
No functional change expected in non-FIPS environments.
[1] https://developers.redhat.com/articles/2025/01/23/fips-mode-red-hat-go-toolset#validating_fips_mode_capabilities
Signed-off-by: Andrew McDermott [email protected]