Skip to content

Conversation

@dave-tucker
Copy link
Contributor

Since some time mid-morning UTC the bpfman-operator image no longer builds since one of the Go dependencies refuses to build on anything other than Go 1.24. This commit bumps the Go version to accomodate.

dave-tucker and others added 2 commits February 25, 2025 13:15
Since some time mid-morning UTC the bpfman-operator image no longer
builds since one of the Go dependencies refuses to build on anything
other than Go 1.24. This commit bumps the Go version to accomodate.

Signed-off-by: Dave Tucker <[email protected]>
Signed-off-by: Billy McFall <[email protected]>
@codecov
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@adda074). Learn more about missing BASE report.
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #383   +/-   ##
=======================================
  Coverage        ?   18.66%           
=======================================
  Files           ?      128           
  Lines           ?    11209           
  Branches        ?        0           
=======================================
  Hits            ?     2092           
  Misses          ?     8909           
  Partials        ?      208           
Flag Coverage Δ
unittests 18.66% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Billy99 Billy99 force-pushed the go-up branch 7 times, most recently from 0558d82 to 67aa0ba Compare February 26, 2025 18:40
The TestApplicationGoCounter in app_test.go is a little flaky,
occasionally failing. Seems to be failing more often with the recent
changes in bpfman. Turns out the log processing was always looking at
the oldest retrieved log, so if it didn't pass on the first read, it
would never pass. It was just random timing if the first log contained
packet counts or not.

Signed-off-by: Billy McFall <[email protected]>
Copy link
Contributor

@anfredette anfredette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@mergify mergify bot merged commit 84b00be into bpfman:main Feb 26, 2025
18 checks passed
msherif1234 pushed a commit to msherif1234/bpfman-operator that referenced this pull request Apr 1, 2025
…8s.io-kube-openapi-digest

chore(deps): update k8s.io/kube-openapi digest to c8a335a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants