fix: guard set_start_method against duplicate calls (GH-466)#483
Open
tomrussobuilds wants to merge 1 commit intoboxed:mainfrom
Open
fix: guard set_start_method against duplicate calls (GH-466)#483tomrussobuilds wants to merge 1 commit intoboxed:mainfrom
tomrussobuilds wants to merge 1 commit intoboxed:mainfrom
Conversation
When mutmut is invoked via the entry-point wrapper (`mutmut run`),
`mutmut.__main__` is cached in `sys.modules` and not re-executed.
When invoked via `python -m mutmut run`, the module is re-executed,
causing `set_start_method("fork")` to raise `RuntimeError: context
has already been set`.
Guard with `get_start_method(allow_none=True)` and emit a warning
when the module is re-executed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #466
When mutmut is invoked via the entry-point wrapper (
mutmut run),mutmut.__main__is cached insys.modulesand not re-executed.When invoked via
python -m mutmut run, the module is re-executed,causing
set_start_method("fork")to raiseRuntimeError: context has already been set.Guard with
get_start_method(allow_none=True)and emit a warningwhen the module is re-executed.