Install desktop file and app icons on Debian #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rico-review
commented
Jun 3, 2020
| ./debian/make-icons.sh | ||
| # Remove the images that `make install` installs: the 1517x1517 png gets installed into 48x48 | ||
| # is just wrong, and the "scalable" svg file is actually just the same PNG stuffed into | ||
| # an svg file because, um. |
There was a problem hiding this comment.
Hmm yes I noticed this. Should we try to get a SVG of the new Ricochet Refresh icon?
|
I think this is resolved, @pospeselr can you confirm when you get a chance? |
|
I've put this back to review are we Ok to merge this or has it already been included? If not, it will potentially be lost/detached when we move to the new repo. |
|
I don't think we should merge as it'll mess with the current debian build system, however the issue here is not resolved, so we still need to solve the icon issue. |
|
OK, I'll leave it open but won't merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.