Skip to content

Conversation

@rakita
Copy link
Member

@rakita rakita commented Dec 2, 2025

Superseeds #3145

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 2, 2025

CodSpeed Performance Report

Merging #3201 will degrade performances by 3.56%

Comparing rakita/journaled-sstore-new (d59e6ea) with main (708be4c)

Summary

⚡ 1 improvement
❌ 1 regression
✅ 171 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
EXTCODECOPY_50 52.3 µs 54.3 µs -3.56%
SSTORE_50 49 µs 39.1 µs +25.29%

@rakita rakita force-pushed the rakita/journaled-sstore-new branch from af2c52c to 995cf69 Compare December 3, 2025 08:34
@rakita rakita changed the base branch from rakita/journaled-account-tr to main December 3, 2025 09:26
@rakita rakita requested a review from klkvr December 3, 2025 09:43
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this basically moves the existing logic from journal/inner into the account?

this is a lot of moved critical code
not trivial to review the changes here so we need to be extra careful

@rakita rakita merged commit 9afd166 into main Dec 9, 2025
30 of 31 checks passed
@rakita rakita deleted the rakita/journaled-sstore-new branch December 9, 2025 22:38
@github-actions github-actions bot mentioned this pull request Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants