{180846526} fix(reqlog): initialize last LSN before diffing #5515
+151
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We get unexpectedly large values in statreqs on database startup because `lastlsn` is not initialized and the "diff" ends up being the total number of log bytes ever written to the database. Initialize `lastlsn` so that LSN diffs are calculated correctly. Signed-off-by: Shoumyo Chakravorti <[email protected]>
roborivers
suggested changes
Oct 22, 2025
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
truncatesc_offline_generated
reco-ddlk-sql
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We get unexpectedly large values in statreqs on database startup because
lastlsnis not initialized and the "diff" ends up being the total number of log bytes ever written to the database. Initializelastlsnso that LSN diffs are calculated correctly.