{180685083} fix(reqlog): do not block statreq updates during schema change #5513
+352
−208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SChakravorti21
commented
Oct 21, 2025
| } | ||
| strbuf_appendf(logstr, "\n"); | ||
| reqlog_logl(statlogger, REQL_INFO, strbuf_buf(logstr)); | ||
| thresh = reqlog_diffstat_thresh(); |
There was a problem hiding this comment.
Diff is mostly indentation and changes applied by the formatting script, actual change is just removing the condition. We go from
if (!get_schema_change_in_progress(__func__, __LINE__)) {
// update statreqs
}to
// update statreqs
roborivers
suggested changes
Oct 22, 2025
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: 1/634 tests failed ⚠.
The first 10 failing tests are:
reco-ddlk-sql
…hange It seems this logic has existed since before schema lock was a thing. The critical section of `statthd` that inspects `dbenv` now acquires the schema lock, so this check should no longer be necessary. Remove the check in `statthd` for whether schema change is in progress so that statreqs are not missing on the master during schema change. Signed-off-by: Shoumyo Chakravorti <[email protected]>
SChakravorti21
force-pushed
the
upd-statreq
branch
from
f73184d to
48717b9
Compare
SChakravorti21
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems this logic has existed since before schema lock was a thing. The critical section of
statthdthat inspectsdbenvnow acquires the schema lock, so this check should no longer be necessary. Remove the check instatthdfor whether schema change is in progress so that statreqs are not missing on the master during schema change.