Skip to content

Conversation

markhannum
Copy link
Contributor

Cherry-picked fixes from Jepsen testing

  1. Introduce loglk, acquired in read-mode by log-cursors, write-mode by vtruncate
  2. Maintain a simple 'active-log-cursors' list
  3. Acquire BDB lock in read-mode for selectv-serial-check in rese_commit

Needs a test- submitting early to see performance under rr/rm

@markhannum markhannum added the WIP Work in Progress label Oct 17, 2025
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
logfill_logput_window_generated
truncatesc
truncatesc_offline_generated
silogdel
selectv_rcode_serialretry_generated
selectv_rcode_serialize_reads_like_writes_generated
selectv_rcode_force_commit_generated
selectv_rcode_disable_svonly_nop_generated
selectv_rcode
log_trigger

@markhannum markhannum force-pushed the log_cursor_lk branch 7 times, most recently from 7c9f1b9 to cb265db Compare October 17, 2025 20:57
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
logfill_logput_window_generated
phys_rep_tiered_nosource_generated
limitsortingtbl
timepart_trunc
phys_rep_tiered_firstfile_generated
phys_rep_tiered
truncatesc_offline_generated
insert_lots
reco-ddlk-sql
phys_rep_via_comdb2_files_generated

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
truncatesc_offline_generated [core dumped]
sc_resume
phys_rep_tiered_nosource_generated
phys_rep_tiered
reco-ddlk-sql

@markhannum markhannum force-pushed the log_cursor_lk branch 2 times, most recently from e9f5ec0 to 4b376be Compare October 18, 2025 14:17
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
physrep_ignore_table

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WIP Work in Progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants