-
Notifications
You must be signed in to change notification settings - Fork 230
{180861602}: tweaking cdb2jdbc retry logic, and making it a regular test #5499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This patch makes the retry-wait logic in cdb2jdbc consistent with cdb2api, specifically in the following 2 places: [250ms wait on each comdb2db retry](https://github.com/bloomberg/comdb2/blob/5d6b2d183ac3ec31274416c2f0b364cc5fb6e0c5/cdb2api/cdb2api.c#L6355) [up to 1000ms wait on run_statement retry](https://github.com/bloomberg/comdb2/blob/5d6b2d183ac3ec31274416c2f0b364cc5fb6e0c5/cdb2api/cdb2api.c#L4767) Signed-off-by: Rivers Zhang <[email protected]>
/adhoc-test cdb2jdbc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 0/0 tests failed ⚠.
cd2092a
to
10593e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 0/0 tests failed ⚠.
10593e9
to
a38f6e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 0/0 tests failed ⚠.
a38f6e2
to
77cf5c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
cdb2jdbc
Signed-off-by: Rivers Zhang <[email protected]>
77cf5c6
to
a6b0c51
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
cdb2jdbc
No description provided.