Port config changes, add got dbinfo var, remove cdb2_clone and include_defaults #5476
Conversation
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: 0/0 tests failed ⚠.
chands10
force-pushed
the
config_changes
branch
4 times, most recently
from
1048179 to
44cfc6f
Compare
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
logfill_logput_window_generated
disttxn
dc
cdb2api_unit
sc_downgrade
chands10
force-pushed
the
config_changes
branch
2 times, most recently
from
37bc3d7 to
d3837d9
Compare
chands10
changed the title
|
|
||
| static int get_connection_int(cdb2_hndl_tp *hndl) | ||
| { | ||
| only_read_config(hndl); |
There was a problem hiding this comment.
I like this function more than the bb-cdb2api equivalent read_cfg_files
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
cdb2_admin
dc
logfill_logput_window_generated
sc_truncate_lockorder_generated
chands10
force-pushed
the
config_changes
branch
3 times, most recently
from
59866c2 to
a5829e7
Compare
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
logfill_logput_window_generated
sc_transactional_rowlocks_generated
cdb2_admin
sc_downgrade
reco-ddlk-sql
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
cldeadlock
|
cdb2test Oct 10 17:52:52 2025 success config_changes.R20251010.10 |
chands10
force-pushed
the
config_changes
branch
from
489c0f5 to
896ecd1
Compare
|
|
||
| static int get_connection(cdb2_hndl_tp *hndl) | ||
| { | ||
| if (hndl->is_admin || (hndl->flags & CDB2_MASTER)) // don't grab from sockpool |
There was a problem hiding this comment.
This is not present in bbcdb2api. Add this line to fix cdb2_admin test
|
Just force pushed to squash commit |
chands10
requested review from
akshatsikarwar
and removed request for
akshatsikarwar
chands10
force-pushed
the
config_changes
branch
from
896ecd1 to
7ecd46e
Compare
|
fixed merge conflict ^^ |
…e_defaults Signed-off-by: Salil Chandra <[email protected]>
chands10
force-pushed
the
config_changes
branch
from
7ecd46e to
2e2a0f1
Compare
|
More merge conflicts ^^ |
2 participants
To help us review your pull request, please consider providing an overview of the following: