serial-commit requires the bdb-lock #5451
Open
+23
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markhannum
force-pushed
the
fix_rese_commit_crash
branch
from
f17852e to
6948c01
Compare
selectv precheck is an optimization Signed-off-by: Mark Hannum <[email protected]>
markhannum
force-pushed
the
fix_rese_commit_crash
branch
from
6948c01 to
c294b2e
Compare
roborivers
suggested changes
Oct 2, 2025
There was a problem hiding this comment.
Coding style check: Error. ⚠.
Smoke testing: Error ⚠.
Cbuild submission: Error ⚠.
Regression testing: 5/631 tests failed ⚠.
The first 10 failing tests are:
selectv_rcode_serialretry_generated
selectv_rcode_serialize_reads_like_writes_generated
selectv_rcode_disable_svonly_nop_generated
selectv_rcode_force_commit_generated
selectv_rcode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug crashed the database in bdb_osql_serial_check when it was unable to find a log record. bdb_osql_serial_check assumes that the caller holds a reference to the bdb_lock, which would prevent logfile truncation. This PR acquires the bob-lock in rese_commit prior checking the generation, and performing the selectv check.