enable_snapshot => enable_serial in serialstep test #5444
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morgando
commented
Sep 30, 2025
| done | ||
| [commit] failed with rc 230 transaction is not serializable | ||
| done | ||
| [commit] failed with rc 230 transaction is not serializable |
There was a problem hiding this comment.
This transaction is serializable in theory, but our implementation is conservative and will sometimes abort transactions that could’ve passed.
roborivers
suggested changes
Sep 30, 2025
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Error ⚠.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.
morgando
commented
Oct 1, 2025
| done | ||
| (rows updated=1) | ||
| done | ||
| [commit] failed with rc -103 selectv constraints |
There was a problem hiding this comment.
This commit should’ve failed all along under our selectv specification. The fact that it didn’t before points to a bug in the selectv genid-checking implementation (which is used outside serializable). With serializable on, we hit the alternative range-checking implementation instead, which does not have the bug.
Signed-off-by: mdouglas47 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/adhoc-test serialstep
This PR updates a test case to comply with the new requirement that all clients running serializable transactions must set
enable_serial_isolation. As a result, a few outputs changed becauseselectv’s range-checking implementation kicks in whenenable_serial_isolationis used. These differences are noted in the PR comments.