Skip to content

Conversation

rishitha957
Copy link
Contributor

Syntax update:

Current syntax:
create default lua consumer foo version 'bar' on (table t for insert of a, b and update of i, j and delete of x, y)

Proposed new syntax:
create default lua consumer foo version 'bar' for (table t on insert include a, b on update include i, j on delete include x, y)

@rishitha957
Copy link
Contributor Author

rishitha957 commented Sep 22, 2025

/adhoc-test consumer

@morgando
Copy link
Contributor

/runtests

@rishitha957 rishitha957 changed the title {DRQS 180541910 <GO>} Lua trigger and consumer syntax update {180541910} Lua trigger and consumer syntax update Sep 22, 2025
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Error ⚠.
Cbuild submission: Error ⚠.
Regression testing: 2/628 tests failed ⚠.

The first 10 failing tests are:
sc_truncate
sc_transactional_rowlocks_generated

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Error ⚠.
Cbuild submission: Error ⚠.
Regression testing: 2/628 tests failed ⚠.

The first 10 failing tests are:
sc_transactional_rowlocks_generated
reco-ddlk-sql

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: 3/630 tests failed ⚠.

The first 10 failing tests are:
logfill_logput_window_generated
sc_downgrade
reco-ddlk-sql

@akshatsikarwar
Copy link
Contributor

akshatsikarwar commented Sep 30, 2025

Don't we need new images for table-event to show INCLUDE?

@rishitha957 rishitha957 force-pushed the lua-syntax-upd branch 2 times, most recently from fac8592 to 83ba508 Compare October 2, 2025 16:23
@chands10 chands10 changed the base branch from main to 8.2 October 9, 2025 15:28
@chands10 chands10 changed the base branch from 8.2 to main October 9, 2025 15:28
@rishitha957 rishitha957 force-pushed the lua-syntax-upd branch 3 times, most recently from feb8e5e to 043940f Compare October 9, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants