Fix[bmqimp]: Close channel on open, reopen, and close timeouts #996
+316
−580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pniedzielski
force-pushed
the
fix/reopen-close
branch
3 times, most recently
from
8a5424c to
f1e5b25
Compare
dorjesinpo
requested changes
Oct 22, 2025
pniedzielski
force-pushed
the
fix/reopen-close
branch
2 times, most recently
from
9a799b6 to
525c1cc
Compare
This patch forces the channel to close when an operation times out while a queue is reopening. In this state, we do not know whether the queue has been successfully reopened or whether it will be in the future if the remote broker catches up. The safest thing to do here is to kill the connection to the broker and try to reconnect anew. Signed-off-by: Patrick M. Niedzielski <[email protected]>
This patch forces the channel to close when an operation times out while a queue is opening. In this state, we do not know whether the queue has been successfully reopened or whether it will be in the future if the remote broker catches up. The safest thing to do here is to kill the connection to the broker and let the user try to open the queue again. Signed-off-by: Patrick M. Niedzielski <[email protected]>
pniedzielski
force-pushed
the
fix/reopen-close
branch
from
525c1cc to
8444ec1
Compare
This patch forces the channel to close when an operation times out while a queue is being closed. In this state, we do not know whether the queue has been successfully closed or whether it will be in the future if the remote broker catches up. The safest thing to do here is to kill the connection to the broker, closing this (and all queues) and letting queues that were open be automatically reopened when we reconnect to a broker. Signed-off-by: Patrick M. Niedzielski <[email protected]>
pniedzielski
force-pushed
the
fix/reopen-close
branch
from
8444ec1 to
d8534bd
Compare
pniedzielski
changed the title
![bmq-oss-ci[bot]](https://avatars.githubusercontent.com/u/1416818?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR causes the client to close the channel to the broker when opening, reopening, or closing a queue times out, rather than marking the queue as expired.