Skip to content

Fix mqbblp::RecoveryMgr: Extend follower wait startup even with avail node #984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix mqbblp::RecoveryMgr: Extend follower wait startup even with avail node #984

wants to merge 1 commit into from

Conversation

kaikulimu
Copy link
Collaborator

@kaikulimu kaikulimu commented Oct 16, 2025 •
edited
Loading

Fixes the flaky test_replica_late_join in legacy mode. A couple remarks:

  1. Choosing an available peer randomly is dangerous, thus I am also guarding this code path behind the retry loop.
  2. k_STARTUP_WAIT_RETRIES = 10 is insufficient when leader is slow. Bumping up to 20. However, we do need to proceed after 20 retries, otherwise test_close_while_reopening fails.

@kaikulimu kaikulimu requested a review from dorjesinpo October 16, 2025 21:18
@kaikulimu kaikulimu requested a review from a team as a code owner October 16, 2025 21:18
@kaikulimu kaikulimu assigned dorjesinpo and kaikulimu and unassigned dorjesinpo Oct 16, 2025
@kaikulimu kaikulimu force-pushed the test-replica-late-join branch from 93885d5 to 7a7824f Compare October 17, 2025 19:31
@kaikulimu kaikulimu changed the title Fix mqbblp::RecoveryMgr: NEVER try to recover ourself without the leader Fix mqbblp::RecoveryMgr: Extend follower wait startup even with avail node Oct 17, 2025
@kaikulimu kaikulimu assigned dorjesinpo and unassigned kaikulimu Oct 17, 2025
bmq-oss-ci[bot]
bmq-oss-ci bot reviewed Oct 17, 2025
View reviewed changes
Copy link

@bmq-oss-ci bmq-oss-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build 3074 of commit 7a7824f has completed with FAILURE

This was referenced Oct 22, 2025
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dorjesinpo dorjesinpo Awaiting requested review from dorjesinpo

1 more reviewer

@bmq-oss-ci bmq-oss-ci[bot] bmq-oss-ci[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@dorjesinpo dorjesinpo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kaikulimu @dorjesinpo