Skip to content

Conversation

jll63
Copy link
Collaborator

@jll63 jll63 commented Jul 22, 2025

This fixes how CI runs the integration tests. Currently, a test that does not use one of the domain_urls fixtures is not executed, because it does not have a consistency pytest mark. To work around this, some tests (e.g. in test_admin_command_routing.py) artificially "use" domain_urls, and do nothing with it (because they don't open any queue).

This PR adds a mark expression to strategy.matrix.consistency to run the tests that don't have the mark.

@jll63 jll63 changed the title Fix[IT]: also execute tests that do not have a consistency mark Fix[IT]: execute tests that do not have a consistency mark Jul 22, 2025
@678098
Copy link
Collaborator

678098 commented Jul 22, 2025

Can we make tests without marks to run on any mode instead, without adding a new matrix value?

@jll63 jll63 force-pushed the ci branch 3 times, most recently from 44d5a00 to c57c516 Compare July 22, 2025 15:58
@jll63
Copy link
Collaborator Author

jll63 commented Jul 22, 2025

Can we make tests without marks to run on any mode instead, without adding a new matrix value?

Wouldn't that run them twice?

@jll63 jll63 requested a review from hallfox July 22, 2025 17:29
@jll63 jll63 marked this pull request as ready for review July 22, 2025 17:29
@jll63 jll63 requested a review from a team as a code owner July 22, 2025 17:29
Copy link

@bmq-oss-ci bmq-oss-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build 2925 of commit 1a02ca4 has completed with FAILURE

Copy link
Collaborator

@678098 678098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. CI is also good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants