Fix: Clang warnings related to switch statements #780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pniedzielski
force-pushed
the
published/fix/warnings/switch
branch
2 times, most recently
from
5ac9dfd to
de91c0b
Compare
![bmq-oss-ci[bot]](https://avatars.githubusercontent.com/u/1416818?s=60&v=4){kind=small}
chrisbeard
reviewed
Jun 16, 2025
src/groups/bmq/bmqp/bmqp_crc32c.cpp
Outdated
| // This code relies on the platform-dependent assumption that the distance | ||
| // from 'data' to next alignment boundary <= 7. This is true on machines | ||
| // with 64-bit word sizes or smaller, but to be safe we assert this. | ||
| BSLS_ASSERT(adj < 8); |
Contributor
There was a problem hiding this comment.
This is probably correct, but may be the only "major" breaking change in this PR from what I see. To be clear, I'm fine with it. We'll revisit this code in the immediate near future with #688 (or similar, based on BDE's implementation).
chrisbeard
previously approved these changes
Jun 16, 2025
Contributor
chrisbeard
left a comment
chrisbeard
left a comment
There was a problem hiding this comment.
lgtm, a second look wouldn't hurt though
hallfox
previously approved these changes
Jun 26, 2025
pniedzielski
force-pushed
the
published/fix/warnings/switch
branch
from
de91c0b to
5fbad40
Compare
Collaborator
Author
|
Recent push fixes bogus conflict with generated bmqex_future component files from 42b2473. |
hallfox
reviewed
Jul 7, 2025
pniedzielski
force-pushed
the
published/fix/warnings/switch
branch
2 times, most recently
from
7646825 to
775bf13
Compare
pniedzielski
force-pushed
the
published/fix/warnings/switch
branch
from
775bf13 to
e2a2191
Compare
pniedzielski
force-pushed
the
published/fix/warnings/switch
branch
2 times, most recently
from
0573609 to
3b2b50f
Compare
This patch adds `BSLA_UNREACHABLE` annotations to `default` cases in exhaustive `switch` statements. Signed-off-by: Patrick M. Niedzielski <[email protected]>
For some exhaustive switch statements, it is a clear logic error if we add an enumerator and forget to add to all places where we switch on it. Previously, this would have been undetectable. This patch adds asserts in places where it is safe to do so. Signed-off-by: Patrick M. Niedzielski <[email protected]>
This patch turns off all warnings in code generated from XSD schemas, which we cannot modify. Signed-off-by: Patrick M. Niedzielski <[email protected]>
There are some cases where it would be catastrophic for the broker to abort due to an unexpected value being provided in a `switch` statement. This value may come over the network, which we have no control over, or from a file on disk, which may have been corrupted. This patch introduces default cases to warn when this happens, but it keeps the current behavior otherwise in these cases. Signed-off-by: Patrick M. Niedzielski <[email protected]>
This patch adds a forgotten case to the `mqbplug_plugintype`, which did not fully handle the new authenticator plugin type. Signed-off-by: Patrick M. Niedzielski <[email protected]>
This patch simplifies the `printOption` function in the `mqbs_filestoreprotocolprinter` component. Before, we were exhaustively switching on an enumeration `bmqp::OptionType` and doing the exact same work in each case. This patch removes the `switch` statement entirely, and replaces it with the work we were doing in all cases. Signed-off-by: Patrick M. Niedzielski <[email protected]>
pniedzielski
force-pushed
the
published/fix/warnings/switch
branch
from
3b2b50f to
d1c8edf
Compare
hallfox
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes warnings that Clang emits due to missing
defaultcases in switch statements.Please see commit messages for more details.