fix: FBS::releaseRef w/o deletion on replica #747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorjesinpo
changed the title
Signed-off-by: dorjesinpo <[email protected]>
dorjesinpo
force-pushed
the
fix/releaseRef-asReplica
branch
from
af5813f to
5c96845
Compare
dorjesinpo
changed the title
![bmq-oss-ci[bot]](https://avatars.githubusercontent.com/u/1416818?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When purging App, replica must decrement refCount but should not attempt to write deletion record.
Calls leading to
releaseRefnow haveasPrimaryas an argument.An alternative would be to use
FileStore::d_isPrimarybut it is interesting to trace all calls explicitly as primary or not.