Use a canonical Python3 version #47
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current check differs from file to file, some require python, some require python3.8. The current version of python is 3.10, and it's backward compatible, so we only need to test if a python version is *below* python3.8 before bailing out. This future proofs the code and allows linux distros and windows installations to use newer python versions.
|
We cannot accept this solution due to internal Python deployment ( uses 3.6, which is not sufficient ). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current check differs from file to file, some require python, some require python3.8.
The current version of python is 3.10, and it's backward compatible,
so we only need to test if a python version is below python3.8 before bailing out.
This future proofs the code and allows linux distros and windows installations to use newer python versions.