Group JSON ingestion schema state#1281
Draft
jwils wants to merge 1 commit into
Draft
Conversation
2bfa200 to
c443df8
Compare
c443df8 to
d660189
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Keep JSON ingestion-specific schema definition state off the shared
SchemaDefinition::Statesurface. This follows up on #1259 by grouping the extension state behind one accessor.What
JSONIngestionStateand attach it viaState#json_ingestion_stateRisk Assessment
Low — internal schema-definition state refactor; public DSL behavior remains unchanged.
References
Validation:
script/lint --fixscript/spellcheck -wscript/type_checkRUBYOPT=--disable-frozen-string-literal bundle exec rake site:doctestbundle exec rspec elasticgraph-json_ingestion/spec/unit/elastic_graph/json_ingestion/schema_definition/deprecated_element_spec.rb elasticgraph-json_ingestion/spec/unit/elastic_graph/json_ingestion/schema_definition/json_schema_spec.rb elasticgraph-json_ingestion/spec/unit/elastic_graph/json_ingestion/schema_definition/indexing/json_schema_with_metadata_spec.rbscript/run_gem_specs elasticgraph-json_ingestionscript/run_gem_specs elasticgraph-schema_definitionandscript/quick_build; local datastore boot is blocked because Docker is not running (~/.docker/run/docker.sockis unavailable).RUBYOPT=--disable-frozen-string-literal bundle exec rake site:validate; the CI-relevant doctest failure is fixed, but local execution later stops insite:npm_installwith an npm dependency resolution issue.