Skip to content

Group JSON ingestion schema state#1281

Draft
jwils wants to merge 1 commit into
mainfrom
joshuaw/json-ingestion-state-container
Draft

Group JSON ingestion schema state#1281
jwils wants to merge 1 commit into
mainfrom
joshuaw/json-ingestion-state-container

Conversation

@jwils

@jwils jwils commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Why

Keep JSON ingestion-specific schema definition state off the shared SchemaDefinition::State surface. This follows up on #1259 by grouping the extension state behind one accessor.

What

  • Add JSONIngestionState and attach it via State#json_ingestion_state
  • Move JSON schema config and deprecated-element registries into the contained state
  • Update typed helpers, specs, doctests, and schema test support to use the contained state

Risk Assessment

Low — internal schema-definition state refactor; public DSL behavior remains unchanged.

References

Validation:

  • script/lint --fix
  • script/spellcheck -w
  • script/type_check
  • RUBYOPT=--disable-frozen-string-literal bundle exec rake site:doctest
  • bundle exec rspec elasticgraph-json_ingestion/spec/unit/elastic_graph/json_ingestion/schema_definition/deprecated_element_spec.rb elasticgraph-json_ingestion/spec/unit/elastic_graph/json_ingestion/schema_definition/json_schema_spec.rb elasticgraph-json_ingestion/spec/unit/elastic_graph/json_ingestion/schema_definition/indexing/json_schema_with_metadata_spec.rb
  • script/run_gem_specs elasticgraph-json_ingestion
  • Not fully run locally: script/run_gem_specs elasticgraph-schema_definition and script/quick_build; local datastore boot is blocked because Docker is not running (~/.docker/run/docker.sock is unavailable).
  • Attempted RUBYOPT=--disable-frozen-string-literal bundle exec rake site:validate; the CI-relevant doctest failure is fixed, but local execution later stops in site:npm_install with an npm dependency resolution issue.

Base automatically changed from joshuaw/json-ingestion-deprecated-apis to main June 30, 2026 22:16
@jwils jwils force-pushed the joshuaw/json-ingestion-state-container branch from 2bfa200 to c443df8 Compare June 30, 2026 23:09
@jwils jwils force-pushed the joshuaw/json-ingestion-state-container branch from c443df8 to d660189 Compare June 30, 2026 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant