build(deps): bump faraday from 2.14.2 to 2.14.3#1272
Merged
Conversation
dependabot
Bot
added
dependencies
dependabot
Bot
requested review from
BrianSigafoos-SQ,
bsorbo,
ellisandrews-toast,
jwils,
jwondrusch,
marcdaniels-toast,
myronmarston and
rossroberts-toast
as code owners
dependabot
Bot
added
dependencies
myronmarston
added a commit
that referenced
this pull request
Jul 1, 2026
## Why A batch of dependency-bump PRs (#1236, #1245, #1267, #1272, #1276, #1277, #1279, #1280) are all failing Steep with `declaration is duplicated` errors. Root cause: the new `elasticgraph-json_ingestion` gem ships RBS signatures (`sig/`) and is a dev dependency of 6 other EG gems, but it was never added to `rbs_collection.yaml` with `ignore: true`. When `rbs collection install` runs, it pulls the gem's signatures in via bundler while those same signatures _also_ exist locally in this monorepo, so Steep sees duplicate declarations and fails. Every EG gem that ships signatures must be ignored in `rbs_collection.yaml` for this reason (see the explanatory comment in that file). Nothing in CI caught the omission. ## What - **Fix**: add `elasticgraph-json_ingestion` to `rbs_collection.yaml` with `ignore: true`. - **Guard**: add a spec to `gem_spec.rb` asserting that the EG gems with a `sig/` directory match (via `match_array`) the `elasticgraph*` entries marked `ignore: true`. This catches both a newly-added gem missing its entry _and_ a stale entry, so this mistake can't recur silently. The bootstrap gem `elasticgraph` (no dash) ships no signatures and is correctly exempt. ## Verification - New spec fails before the yaml fix (`missing elements: ["elasticgraph-json_ingestion"]`), passes after. - `bundle exec rspec elasticgraph/spec/unit/elastic_graph/gem_spec.rb` → 205 examples, 0 failures. - `script/type_check` → No type error detected. 🫖 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Collaborator
|
🤖 (via Claude Code on Myron's behalf) @dependabot recreate |
dependabot
Bot
force-pushed
the
dependabot/bundler/faraday-2.14.3
branch
from
2eb0a35 to
4eae780
Compare
Collaborator
|
@dependabot recreate |
Bumps [faraday](https://github.com/lostisland/faraday) from 2.14.2 to 2.14.3. - [Release notes](https://github.com/lostisland/faraday/releases) - [Changelog](https://github.com/lostisland/faraday/blob/main/CHANGELOG.md) - [Commits](lostisland/faraday@v2.14.2...v2.14.3) --- updated-dependencies: - dependency-name: faraday dependency-version: 2.14.3 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/bundler/faraday-2.14.3
branch
from
a581790 to
0406495
Compare
myronmarston
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps faraday from 2.14.2 to 2.14.3.
Release notes
Sourced from faraday's releases.
Commits
f1ace87Version bump to 2.14.336764bfMerge commit from fork59334e0feat(test): add Stubs#clear to remove all stubs (#1675)469f25cUpgrade CI lint step from Ruby 3 to 4 (#1673)