-
Notifications
You must be signed in to change notification settings - Fork 8
Restructuring repository based on feedback #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't review exhaustively (such as README
contents) but this seems solid. Once it merges and we prepare for release we can do a thorough review of current repository contents.
Optional and can be done later: changing the Renovate config file match here too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Structure changes LGTM, one small thing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested local CLI workflow, VS Code debugger, and tests ✅
Thanks for doing this so quickly!
Co-authored-by: Vince Grassia <[email protected]>
🎟️ Tracking
🚧 Type of change
📔 Objective
Restructuring repository based on feedback from Matt Bishop.
📋 Code changes
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes