Skip to content

Restructuring repository based on feedback #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 14, 2024
Merged

Conversation

jhbeskow
Copy link
Contributor

🎟️ Tracking

🚧 Type of change

  • 🧹 Tech debt (refactoring, code cleanup, dependency upgrades, etc.)

📔 Objective

Restructuring repository based on feedback from Matt Bishop.

📋 Code changes

  • Multiple: All changes are based on refactoring request

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@jhbeskow jhbeskow requested a review from a team May 14, 2024 13:33
@jhbeskow jhbeskow requested a review from a team as a code owner May 14, 2024 13:33
@withinfocus withinfocus changed the title Restructuring repository based on feedback from Matt Bishop Restructuring repository based on feedback May 14, 2024
Copy link
Contributor

@withinfocus withinfocus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't review exhaustively (such as README contents) but this seems solid. Once it merges and we prepare for release we can do a thorough review of current repository contents.

Optional and can be done later: changing the Renovate config file match here too.

Copy link
Contributor

@Thomas-Avery Thomas-Avery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Structure changes LGTM, one small thing

Copy link
Contributor

@tangowithfoxtrot tangowithfoxtrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested local CLI workflow, VS Code debugger, and tests ✅

Thanks for doing this so quickly!

@jhbeskow jhbeskow requested a review from vgrassia May 14, 2024 20:02
@jhbeskow jhbeskow merged commit 4062751 into main May 14, 2024
4 checks passed
@jhbeskow jhbeskow deleted the features/restructure_repo branch May 14, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants