Skip to content

Conversation

@gitclonebrian
Copy link

@gitclonebrian gitclonebrian commented Nov 26, 2025

๐ŸŽŸ๏ธ Tracking

BRE-1333

๐Ÿ“” Objective

Adjust workflow and app token permissions to align with least privilege best practices.

  • Add empty permission set at workflow level to remove default GITHUB_TOKEN permissions
  • Remove contents:write from bump_version job as git operations use the GitHub App token
  • Add contents:write to GitHub App token for checkout and git push operations

๐Ÿ“ธ Screenshots

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

- Add empty permission set at workflow level to remove default GITHUB_TOKEN permissions
- Remove contents:write from bump_version job as git operations use the GitHub App token
- Add contents:write to GitHub App token for checkout and git push operations
@github-actions
Copy link

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 3c179813-ae60-4321-a458-17bf3c312a56

Great job! No new security vulnerabilities introduced in this pull request

@gitclonebrian gitclonebrian marked this pull request as ready for review November 26, 2025 03:41
@gitclonebrian gitclonebrian requested a review from a team as a code owner November 26, 2025 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants