feat: better support for more runner types #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed Issues (7)Great job! The following issues were fixed in this Pull Request
|
we still default to US cloud region if no URLs are provided
|
tangowithfoxtrot
force-pushed
the
rewrite-it-in-rust
branch
2 times, most recently
from
6b3f31d to
3a6b919
Compare
|
tangowithfoxtrot
changed the title
Co-authored-by: Justin Baur <[email protected]>
tangowithfoxtrot
force-pushed
the
rewrite-it-in-rust
branch
from
ad89517 to
ed2ece1
Compare
justindbaur
reviewed
Oct 29, 2025
Member
justindbaur
left a comment
justindbaur
left a comment
There was a problem hiding this comment.
One tiny thing but otherwise looks great.
src/ci.rs
Outdated
| debug!("Writing to GITHUB_ENV: {env_path}"); | ||
|
|
||
| let env_file = OpenOptions::new() | ||
| .create(true) // needed for unit tests |
Member
There was a problem hiding this comment.
Actually shouldn't need these anymore! (another one below)
pixman20
previously approved these changes
Nov 4, 2025
pixman20
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/SM-1559
📔 Objective
Switch from a TypeScript Action that relies on our NAPI/WASM packages, to one written in Rust. This enables a few things:
Switching to a Rust-based Action does introduce some challenges. We will now need compiled binaries for the various Runner types (Linux, macOS, Windows, ARM64 and x86_64), so we also need a workflow that builds and releases the binaries so they can be downloaded at runtime, rather than being built from source every time our Action is invoked.
There is a fallback mode that will build the sm-action binaries from source at runtime in the event that they can't be downloaded from GitHub Releases (in something like an API degradation scenario). This is a highly unideal edge case because compiling at runtime would take ~5-6 minutes, but it seems highly unlikely that users would get a successful workflow run if GH APIs are degraded anyway. Still, I left the fallback mode there because it also makes local dev easy.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes