[PM-35791] Remove email verification FF and legacy Send access endpoints

[mcamirault]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-35791

📔 Objective

This PR removes the feature flag that was used to introduce email-authenticated Sends and two endpoints that used to be used for Send access (along with their associated tests). I also updated some imports that were marked as deprecated since I was modifying the files anyway. This PR should not be merged before this SDK pull request

📸 Screenshots

No UI changes

[github-actions]

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR removes the pm-19051-send-email-verification feature flag constant (already unreferenced in server code), deletes the two legacy anonymous Send access endpoints (POST sends/access/{id} and POST sends/{encodedSendId}/access/file/{fileId}) with their tests, and migrates SendsController and SendAccessResponseModel off the soft-deprecated Bit.Core.Services.IFeatureService and Bit.Core.Models.Api.ResponseModel. The deprecation migrations match the existing convention (fully-qualified Bitwarden.Server.Sdk.Features.IFeatureService, as in OrganizationUsersController), and Bit.HttpExtensions.ResponseModel is behaviorally equivalent for the constant "send-access" object name. Remaining AccessUsingAuth / GetSendFileDownloadDataUsingAuth coverage (including HideEmail, access-count, and event-logging cases) still exercises the paths the deleted tests covered.

Code Review Details

• ♻️ : Removal leaves the anonymous Send access stack as dead production code — unread _anonymousSendCommand dependency, plus AnonymousSendCommand, ISendAuthorizationService.AccessAsync, and SendAccessRequestModel with no remaining production callers
  • src/Api/Tools/Controllers/SendsController.cs:36
• ❓ : Confirm all still-supported clients (notably independently-updated CLI builds and lagging self-hosted installs) no longer call the removed anonymous access routes
  • src/Api/Tools/Controllers/SendsController.cs (removed endpoints)

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.62%. Comparing base (a607062) to head (f32a37a).
⚠️ Report is 16 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8065      +/-   ##
==========================================
+ Coverage   62.49%   62.62%   +0.13%     
==========================================
  Files        2305     2295      -10     
  Lines      100045    99936     -109     
  Branches     8998     8985      -13     
==========================================
+ Hits        62522    62588      +66     
+ Misses      35347    35182     -165     
+ Partials     2176     2166      -10     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.