[PM-26772] Importing Archived Ciphers

[nick-livefront]

🎟️ Tracking

PM-26772

📔 Objective

When importing archived ciphers:

• Into an organization, throw an error. Archived ciphers are not allowed in organizations
• Into a personal vault, persist the archive date so the ciphers still appear in the archived vault.

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[codecov]

Codecov Report

❌ Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.81%. Comparing base (42568b6) to head (3d374b0).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...c/Api/Tools/Controllers/ImportCiphersController.cs	25.00%	2 Missing and 1 partial ⚠️
...dminConsole/Helpers/BulkResourceCreationService.cs	66.66%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6452      +/-   ##
==========================================
+ Coverage   50.73%   54.81%   +4.07%     
==========================================
  Files        1866     1866              
  Lines       82705    82704       -1     
  Branches     7310     7321      +11     
==========================================
+ Hits        41961    45332    +3371     
+ Misses      39143    35690    -3453     
- Partials     1601     1682      +81     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

Checkmarx One – Scan Summary & Details – 9a46da06-c74e-4670-8645-ed40b1cf1eb3

Great job! No new security vulnerabilities introduced in this pull request

[djsmith85]

⚠️ A more efficient way to check this, is to use Any() to filter, as it will exit as soon as it finds a match. Calling Where() and ToList() will execute on all ciphers to create a separate List of ciphers, which then is just checked once and not needed anymore.

Suggested change

	var archivedCiphers = model.Ciphers.Where(c => c.ArchivedDate.HasValue).ToList();
	if (archivedCiphers.Any())
	{
	throw new BadRequestException("You cannot import archived items into an organization.");
	}
	if (model.Ciphers.Any(c => c.ArchivedDate.HasValue))
	{
	throw new BadRequestException("You cannot import archived items into an organization.");
	}

[djsmith85]

⚠️ There's no test to verify importing into an organization with archived ciphers will throw a BadRequestException