Skip to content

Conversation

amorask-bitwarden
Copy link
Contributor

@amorask-bitwarden amorask-bitwarden commented Oct 13, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-26793

📔 Objective

When the feature flag pm-26793-fetch-premium-price-from-pricing-service is enabled, fetches premium price data from the Pricing Service using the endpoint added here: https://github.com/bitwarden/billing-pricing/pull/41 and then surfaces it through its own endpoint in API for consumption by the web app.

Pricing Service PR: https://github.com/bitwarden/billing-pricing/pull/41
Clients PR: bitwarden/clients#16858

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Oct 13, 2025

Logo
Checkmarx One – Scan Summary & Detailsbf8be232-f6d6-4334-9425-2ca5bc82e146

Great job! No new security vulnerabilities introduced in this pull request

Copy link

codecov bot commented Oct 13, 2025

Codecov Report

❌ Patch coverage is 25.00000% with 54 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.71%. Comparing base (42568b6) to head (0fc4271).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/Core/Billing/Pricing/PricingClient.cs 2.32% 41 Missing and 1 partial ⚠️
src/Api/Billing/Controllers/PlansController.cs 0.00% 4 Missing ⚠️
...vices/Implementations/PremiumUserBillingService.cs 40.00% 3 Missing ⚠️
...e/Services/Implementations/StripePaymentService.cs 0.00% 3 Missing ⚠️
src/Core/Services/Implementations/UserService.cs 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6450      +/-   ##
==========================================
- Coverage   50.73%   50.71%   -0.03%     
==========================================
  Files        1866     1868       +2     
  Lines       82705    82742      +37     
  Branches     7310     7324      +14     
==========================================
- Hits        41961    41960       -1     
- Misses      39143    39179      +36     
- Partials     1601     1603       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants