[PM-26361] Add User Auto Confirmation #6436

jrmccannon · 2025-10-09T20:52:41Z

🎟️ Tracking

📔 Objective

This adds AutomaticUserConfirmation to Organization, OrganizationAbility, OrganizationLicense, and Plan. This also adds it to the Admin portal as a checkable box for Organization features. This also adds the feature to the claims factory and claim constant.

📸 Screenshots

Admin Portal Checkbox

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

github-actions · 2025-10-09T21:04:43Z

Checkmarx One – Scan Summary & Details – aa225de5-c039-44ec-a0b8-255835c5cfd1

New Issues (3)

Checkmarx found the following issues in this Pull Request

Issue	Source File / Package	Checkmarx Insight
CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 1526	details Method at line 1526 of /src/Api/Vault/Controllers/CiphersController.cs gets a parameter from a user request from id. This parameter value flows ... `ID: QoPFIn33sdQMftvYHIrA5m2sTvA%3D` Attack Vector
CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 1407	details Method at line 1407 of /src/Api/Vault/Controllers/CiphersController.cs gets a parameter from a user request from id. This parameter value flows ... `ID: BckEUZHi2Zah%2BqUsgB4HvfICDBw%3D` Attack Vector
CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 251	details Method at line 251 of /src/Api/Vault/Controllers/CiphersController.cs gets a parameter from a user request from id. This parameter value flows t... `ID: ywF7SV4TBXJ5%2BlPTW0fv0uKgRzc%3D` Attack Vector

Fixed Issues (1)

Great job! The following issues were fixed in this Pull Request

Severity	Issue	Source File / Package
	~~CSRF~~	/src/Api/Vault/Controllers/CiphersController.cs: 299

r-tome

Looking at the documentation this is missing some updates:

Add the new column to the following sprocs and views:
Organization_Create.sql
Organization_ReadAbilities.sql
Organization_Update.sql
OrganizationUserOrganizationDetailsView.sql
ProviderUserProviderOrganizationDetailsView.sql

Add the new property to the following models:
src/Api/AdminConsole/Models/Response/Organizations/OrganizationResponseModel.cs
src/Api/AdminConsole/Models/Response/ProfileOrganizationResponseModel.cs
src/Api/AdminConsole/Models/Response/ProfileProviderOrganizationResponseModel.cs
src/Core/AdminConsole/Models/Data/Organizations/OrganizationUsers/OrganizationUserOrganizationDetails.cs
src/Core/AdminConsole/Models/Data/Provider/ProviderUserOrganizationDetails.cs

src/Admin/AdminConsole/Models/OrganizationEditModel.cs

codecov · 2025-10-10T13:42:26Z

Codecov Report

❌ Patch coverage is 68.96552% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.88%. Comparing base (42568b6) to head (8127de9).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...AdminConsole/Views/Shared/_OrganizationForm.cshtml	0.00%	3 Missing ⚠️
...illing/Organizations/Models/OrganizationLicense.cs	50.00%	3 Missing ⚠️
...Admin/AdminConsole/Models/OrganizationEditModel.cs	33.33%	2 Missing ⚠️
...mplementations/OrganizationLicenseClaimsFactory.cs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6436      +/-   ##
==========================================
+ Coverage   50.73%   54.88%   +4.15%     
==========================================
  Files        1866     1866              
  Lines       82705    82722      +17     
  Branches     7310     7321      +11     
==========================================
+ Hits        41961    45404    +3443     
+ Misses      39143    35639    -3504     
- Partials     1601     1679      +78

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…onse models. Updating sprocs and views. Updating migrations

sbrown-livefront

Billing changes look good!

mkincaid-bw

Mostly nit-picks and one concern about refreshing views.

mkincaid-bw · 2025-10-13T22:25:06Z

src/Sql/dbo/Stored Procedures/Organization_Update.sql


-    UPDATE
-        [dbo].[Organization]
+    UPDATE [dbo].[Organization]


⛏️ The UPDATE and table name should be on their own lines

mkincaid-bw · 2025-10-13T22:26:15Z

src/Sql/dbo/Stored Procedures/Organization_Update.sql

-        [Id] = @Id
+        [SyncSeats] = @SyncSeats,
+        [UseAutomaticUserConfirmation] = @UseAutomaticUserConfirmation
+    WHERE [Id] = @Id;


⛏️ The WHERE and column name(s) should be on their own lines

mkincaid-bw · 2025-10-13T22:27:20Z

src/Sql/dbo/Tables/Organization.sql

    [UseOrganizationDomains]        BIT              NOT NULL CONSTRAINT [DF_Organization_UseOrganizationDomains] DEFAULT (0),
    [UseAdminSponsoredFamilies]     BIT              NOT NULL CONSTRAINT [DF_Organization_UseAdminSponsoredFamilies] DEFAULT (0),
    [SyncSeats]                     BIT              NOT NULL CONSTRAINT [DF_Organization_SyncSeats] DEFAULT (0),
+    [UseAutomaticUserConfirmation]     BIT           NOT NULL CONSTRAINT [DF_Organization_UseAutomaticUserConfirmation] DEFAULT (0),


⛏️ The BIT data type should be vertically aligned with the one above it.

mkincaid-bw · 2025-10-13T22:29:17Z

util/Migrator/DbScripts/2025-10-07_00_AddAutoConfirmUser.sql

⛏️ All if your file names have AddAutoConfrimUser instead of AddAutoConfirmUser

mkincaid-bw · 2025-10-13T22:30:08Z

util/Migrator/DbScripts/2025-10-07_00_AddAutoConfirmUser.sql

+BEGIN
+    SET NOCOUNT ON
+
+    UPDATE [dbo].[Organization]


⛏️ The UPDATE and table name should be on their own lines

mkincaid-bw · 2025-10-13T22:30:41Z

util/Migrator/DbScripts/2025-10-07_00_AddAutoConfirmUser.sql

+        [UseAdminSponsoredFamilies] = @UseAdminSponsoredFamilies,
+        [SyncSeats] = @SyncSeats,
+        [UseAutomaticUserConfirmation] = @UseAutomaticUserConfirmation
+    WHERE [Id] = @Id;


⛏️ The WHERE and column name(s) should be on their own lines

mkincaid-bw · 2025-10-13T22:34:04Z

util/Migrator/DbScripts/2025-10-07_00_AddAutoConfirmUser.sql

+    [dbo].[Provider] P ON P.[Id] = PU.[ProviderId]
+GO
+
+EXEC sp_refreshview '[dbo].[OrganizationView]';


Any view that touches a modified table should be refreshed (regardless if they are using the new columns). Since you modified two, those are fine, but these should also be refreshed:

EXEC sp_refreshview '[dbo].[OrganizationCipherDetailsCollectionsView]'; EXEC sp_refreshview '[dbo].[ProviderOrganizationOrganizationDetailsView]';

jrmccannon added 6 commits October 9, 2025 10:13

Adding AutoConfrim and migrations.

e9a5c8c

Add value to Admin Page and update sproc to correct name.

481727f

Correcting license constant.

ebca4f9

Adding feature check back in.

a5e5085

Fixing sprocs :face_palm:

ec71b7a

Remove Coalesce

dd11517

r-tome requested changes Oct 10, 2025

View reviewed changes

src/Admin/AdminConsole/Models/OrganizationEditModel.cs Show resolved Hide resolved

Adding property to plan and model constructor

c7dae17

Correcting name of column. Cascading change throughout. Updating resp…

7a02959

…onse models. Updating sprocs and views. Updating migrations

jrmccannon requested a review from r-tome October 10, 2025 14:49

jrmccannon added 5 commits October 10, 2025 09:52

fixing sproc

1df6aae

Fixing up license stuff.

06dcfd2

Merge branch 'main' into jmccannon/ac/pm-26361-add-auto-confirm

d779433

Merge branch 'main' into jmccannon/ac/pm-26361-add-auto-confirm

d4d9af7

Updating org view

1081984

jrmccannon marked this pull request as ready for review October 13, 2025 16:41

jrmccannon requested review from a team as code owners October 13, 2025 16:41

jrmccannon requested a review from sbrown-livefront October 13, 2025 16:41

sbrown-livefront previously approved these changes Oct 13, 2025

View reviewed changes

mkincaid-bw requested changes Oct 13, 2025

View reviewed changes

Code review changes and renames :face_palm:

3fcc118

jrmccannon dismissed sbrown-livefront’s stale review via 3fcc118 October 13, 2025 23:38

Refershing additional views

ecf53ec

jrmccannon requested review from mkincaid-bw and sbrown-livefront October 14, 2025 00:15

Last two fixes.

8127de9

[PM-26361] Add User Auto Confirmation #6436

Are you sure you want to change the base?

[PM-26361] Add User Auto Confirmation #6436

Conversation

jrmccannon commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎟️ Tracking

📔 Objective

📸 Screenshots

⏰ Reminders before review

🦮 Reviewer guidelines

Uh oh!

github-actions bot commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

r-tome left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov bot commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sbrown-livefront left a comment

Choose a reason for hiding this comment

Uh oh!

mkincaid-bw left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jrmccannon commented Oct 9, 2025 •

edited

Loading

github-actions bot commented Oct 9, 2025 •

edited

Loading

codecov bot commented Oct 10, 2025 •

edited

Loading