Skip to content

Conversation

r-tome
Copy link
Contributor

@r-tome r-tome commented Oct 9, 2025

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/PM-26714

๐Ÿ“” Objective

Add unit tests to cover the organization auto-scaling email scenario, which was previously untested.

One test asserts that the email is sent when auto-scaling occurs for the first time (OwnersNotifiedOfAutoscaling is null), and another asserts that no email is sent when auto-scaling has already occurred (OwnersNotifiedOfAutoscaling is not null).

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Oct 9, 2025

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 2474ba5f-ed67-421c-9c30-90bf24427ac5

Great job! No new security vulnerabilities introduced in this pull request

Copy link

codecov bot commented Oct 9, 2025

Codecov Report

โœ… All modified and coverable lines are covered by tests.
โœ… Project coverage is 50.58%. Comparing base (3bef572) to head (67f4a9d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6434      +/-   ##
==========================================
+ Coverage   50.55%   50.58%   +0.03%     
==========================================
  Files        1854     1854              
  Lines       82169    82169              
  Branches     7270     7270              
==========================================
+ Hits        41537    41566      +29     
+ Misses      39043    39012      -31     
- Partials     1589     1591       +2     

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

๐Ÿš€ New features to boost your workflow:
  • โ„๏ธ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • ๐Ÿ“ฆ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant