Initial PoC of seeder API #6424
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## arch/seeder-sdk #6424 +/- ##
===================================================
- Coverage 50.55% 50.54% -0.01%
===================================================
Files 1854 1854
Lines 82169 82169
Branches 7270 7260 -10
===================================================
- Hits 41537 41536 -1
- Misses 39043 39044 +1
Partials 1589 1589 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
New Issues (1)Checkmarx found the following issues in this Pull Request
Fixed Issues (1)Great job! The following issues were fixed in this Pull Request
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| { | ||
| public Guid Id { get; set; } | ||
| public required string RecipeName { get; set; } | ||
| public required string Data { get; set; } // JSON blob with entity tracking info |
There was a problem hiding this comment.
❌ We should refrain from inline comments as they don't help us craft clean code. I recommend that we either remove or add an XML comment but I prefer the prior and avoid it altogether.
There was a problem hiding this comment.
❌ None of the comments in the Program.cs file help the next teammate understand the program better than intellisense already does. I recommend that we remove them.
MGibson1
force-pushed
the
arch/seeder-api
branch
from
abd2d4b to
2bbf7d1
Compare
MGibson1
force-pushed
the
arch/seeder-api
branch
from
2bbf7d1 to
d93cd50
Compare
Fixup single user recipe to inform of seeded entities
…ch/seeder-api # Conflicts: # util/Seeder/Factories/UserSeeder.cs
|
3 participants
🎟️ Tracking
📔 Objective
Adds a standalone API service which allows you to run and destroy seeds. The intention is to allow integration tests to seed the database.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes