[PM-19563] - remove pm-18520-desktop-cipher-forms feature flag

[jaasen-livefront]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-19563

📔 Objective

Note

Was a pure UI update so no server-side checks to remove other than the feature flag itself.

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.35%. Comparing base (4450d43) to head (4af658f).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6419      +/-   ##
==========================================
- Coverage   50.35%   50.35%   -0.01%     
==========================================
  Files        1853     1853              
  Lines       82394    82394              
  Branches     7265     7265              
==========================================
- Hits        41493    41490       -3     
- Misses      39319    39321       +2     
- Partials     1582     1583       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

Checkmarx One – Scan Summary & Details – 29244385-67a5-447f-bc5a-b52402ea31ef

Great job! No new security vulnerabilities introduced in this pull request