-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[PM-25183] Update the BitPay purchasing procedure #6396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6396 +/- ##
==========================================
+ Coverage 50.31% 50.53% +0.22%
==========================================
Files 1852 1849 -3
Lines 82233 82104 -129
Branches 7244 7231 -13
==========================================
+ Hits 41376 41493 +117
+ Misses 39282 39033 -249
- Partials 1575 1578 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Great job! No new security vulnerabilities introduced in this pull request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small nitpick, otherwise looks good!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-25183
📔 Objective
Our BitPay integration has been broken for some time and part of the reason for that is:
This PR accomplishes both of those things by:
server
-level changes necessary to act on our updated BitPay configurations which allows for testing in lower environments📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes