Skip to content

Conversation

amorask-bitwarden
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-25183

📔 Objective

Our BitPay integration has been broken for some time and part of the reason for that is:

  1. We've never investigated how the integration is configured
  2. We never set up a lower environment testing process

This PR accomplishes both of those things by:

  1. Implementing the server-level changes necessary to act on our updated BitPay configurations which allows for testing in lower environments
  2. Refactoring the webhook processor to be more readable and add logging and tests

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@amorask-bitwarden amorask-bitwarden requested a review from a team as a code owner September 29, 2025 16:10
Copy link

codecov bot commented Sep 29, 2025

Codecov Report

❌ Patch coverage is 95.65217% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.53%. Comparing base (1dc4c32) to head (8c36fe1).

Files with missing lines Patch % Lines
src/Billing/Controllers/BitPayController.cs 95.16% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6396      +/-   ##
==========================================
+ Coverage   50.31%   50.53%   +0.22%     
==========================================
  Files        1852     1849       -3     
  Lines       82233    82104     -129     
  Branches     7244     7231      -13     
==========================================
+ Hits        41376    41493     +117     
+ Misses      39282    39033     -249     
- Partials     1575     1578       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Sep 29, 2025

Logo
Checkmarx One – Scan Summary & Details3f3129fc-6c25-430e-a601-d11b66a36522

Great job! No new security vulnerabilities introduced in this pull request

Copy link
Contributor

@kdenney kdenney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small nitpick, otherwise looks good!

Copy link

sonarqubecloud bot commented Oct 2, 2025

Copy link
Contributor

@kdenney kdenney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants