-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[PM-21079] Add support to integration tests for using sqlserver #5823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
New Issues (1)Checkmarx found the following issues in this Pull Request
Fixed Issues (3)Great job! The following issues were fixed in this Pull Request
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5823 +/- ##
==========================================
+ Coverage 47.28% 47.59% +0.30%
==========================================
Files 1645 1663 +18
Lines 74703 75260 +557
Branches 6724 6764 +40
==========================================
+ Hits 35325 35819 +494
- Misses 37921 37976 +55
- Partials 1457 1465 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, just a few minor questions.
test/IntegrationTestCommon/Factories/WebApplicationFactoryBase.cs
Outdated
Show resolved
Hide resolved
test/IntegrationTestCommon/Factories/WebApplicationFactoryBase.cs
Outdated
Show resolved
Hide resolved
test/IntegrationTestCommon/Factories/WebApplicationFactoryBase.cs
Outdated
Show resolved
Hide resolved
|
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-21079
📔 Objective
Adds a
SqlServerApiApplicationFactory
which allows you to run api tests using SqlServer. Currently a new database is create and destroyed for each test. In the future we'd like a more optimized way to do this.The database logic is abstracted away in a
ITestDatabase
interface which handles the configuration, migration and teardown.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes